Thread (10 messages) 10 messages, 4 authors, 2025-02-19

Re: [PATCH 1/4] dt-bindings: clock: imx8mp: add axi clock

From: Frank Li <Frank.li@nxp.com>
Date: 2025-02-18 16:06:02
Also in: imx, linux-clk, linux-devicetree, lkml

On Mon, Feb 17, 2025 at 11:57:15AM -0500, Laurentiu Mihalcea wrote:
quoted hunk ↗ jump to hunk
From: Laurentiu Mihalcea <redacted>

The AUDIOMIX clock provider takes an additional clock: AUDIO_AXI_CLK_ROOT.

Signed-off-by: Laurentiu Mihalcea <redacted>
---
 .../devicetree/bindings/clock/imx8mp-audiomix.yaml     | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/imx8mp-audiomix.yaml b/Documentation/devicetree/bindings/clock/imx8mp-audiomix.yaml
index 6588a17a7d9a..0272c9527037 100644
--- a/Documentation/devicetree/bindings/clock/imx8mp-audiomix.yaml
+++ b/Documentation/devicetree/bindings/clock/imx8mp-audiomix.yaml
@@ -24,8 +24,8 @@ properties:
     maxItems: 1

   clocks:
-    minItems: 7
-    maxItems: 7
+    minItems: 8
+    maxItems: 8
Are you sure clock axi is mandatory or optional clock?

If it is mandatory, you need update dts also, otherwise, there will many
DTB_CHECK warning.

If it is optional, minItems should be 7.

Please run CEHCK_DTB for arm64/dts/boot/freescale, make sure no new warning
added.

Frank
quoted hunk ↗ jump to hunk
   clock-names:
     items:
@@ -36,6 +36,7 @@ properties:
       - const: sai5
       - const: sai6
       - const: sai7
+      - const: axi

   '#clock-cells':
     const: 1
@@ -72,10 +73,11 @@ examples:
                  <&clk IMX8MP_CLK_SAI3>,
                  <&clk IMX8MP_CLK_SAI5>,
                  <&clk IMX8MP_CLK_SAI6>,
-                 <&clk IMX8MP_CLK_SAI7>;
+                 <&clk IMX8MP_CLK_SAI7>,
+                 <&clk IMX8MP_CLK_AUDIO_AXI_ROOT>;
         clock-names = "ahb",
                       "sai1", "sai2", "sai3",
-                      "sai5", "sai6", "sai7";
+                      "sai5", "sai6", "sai7", "axi";
         power-domains = <&pgc_audio>;
     };

--
2.34.1
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help