Re: [PATCH v3 4/6] scripts/sorttable: Zero out weak functions in mcount_loc table

From
Steven Rostedt <rostedt@goodmis.org>
Date
2025-02-17 15:20:38
Also in
bpf, linux-kbuild, linux-s390, linux-trace-kernel, lkml
Reply to
Jiri Olsa, 2025-02-14
On Fri, 14 Feb 2025 23:14:26 +0100
Jiri Olsa [off-list ref] wrote:
quoted
+	while (fscanf(fp, "%16s %16s %c %*s\n", addr_str, size_str, &type) == 3) {
+		uint64_t addr;
+		uint64_t size;
+
+		/* Only care about functions */
+		if (type != 't' && type != 'T')
+			continue;  
hi,
I think we need the 'W' check in here [1]
Good catch!
jirka


[1] https://lore.kernel.org/bpf/20250103071409.47db1479@batman.local.home/ (local)
Bah, I just pulled from patchwork and forgot about that fix.

Will send a v4.

-- Steve
Thread (9 messages) 9 messages, 2 authors, last reply 2025-02-17
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help