Re: [PATCH v2 13/15] arm64: dts: imx8mm-phycore-som: Add overlay for rproc
From: Shawn Guo <hidden>
Date: 2025-02-17 10:12:29
Also in:
imx, linux-devicetree, lkml
On Tue, Dec 31, 2024 at 08:34:32AM +0100, Andrej Picej wrote:
quoted
quoted
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-phycore-rpmsg.dtso b/arch/arm64/boot/dts/freescale/imx8mm-phycore-rpmsg.dtso new file mode 100644 index 000000000000..0c61946f0cf8 --- /dev/null +++ b/arch/arm64/boot/dts/freescale/imx8mm-phycore-rpmsg.dtso@@ -0,0 +1,55 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (C) 2024 PHYTEC Messtechnik GmbH + * Author: Dominik Haller <d.haller@phytec.de> + */ + +/dts-v1/; +/plugin/; + +#include <dt-bindings/clock/imx8mm-clock.h> + +&{/} { + reserved-memory { + #address-cells = <2>; + #size-cells = <2>; + ranges;I'm getting this: arch/arm64/boot/dts/freescale/imx8mm-phycore-rpmsg.dtso:16.3-10: Warning (ranges_format): /fragment@0/__overlay__/reserved-memory:ranges: empty "ranges" property but its #size-cells (2) differs from /fragment@0/__overlay__ (1) arch/arm64/boot/dts/freescale/imx8mm-phycore-rpmsg.dtso:13.18-43.4: Warning (avoid_default_addr_size): /fragment@0/__overlay__/reserved-memory: Relying on default #address-cells value arch/arm64/boot/dts/freescale/imx8mm-phycore-rpmsg.dtso:13.18-43.4: Warning (avoid_default_addr_size): /fragment@0/__overlay__/reserved-memory: Relying on default #size-cells valueI see, missed this before, sorry. But I have some problems fixing it. I think the problem is that this is overlay, the same node put in the imx8mm-phycore-som.dtsi doesn't trigger a warning. The only solution that I found is that I specify the default address-cells and size-cells in root node: &{/} { #address-cells = <2>; #size-cells = <2>; reserved-memory { #address-cells = <2>; #size-cells = <2>; ranges; ... }; }; The same values are used in imx8mm.dtsi, but the checker fails to find these default values. Not sure if this is the right solution, though. Your input would be helpful, thanks.
Unless DT folks have better suggestion, I'm fine with this. Shawn