Re: [PATCH RFC 1/3] dt-bindings: crypto: Add binding for TI DTHE V2 driver
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-02-09 12:27:52
Also in:
linux-crypto, linux-devicetree, lkml
On Thu, Feb 06, 2025 at 02:44:30PM +0530, T Pratham wrote:
Add new DT binding for Texas Instruments DTHE V2 crypto driver.
This was never tested so only limited review. Subject and commit msg: Bindings are for hardware, not driver. Rephrase to accurately describe the hardware.
quoted hunk ↗ jump to hunk
DTHE V2 is introduced as a part of TI AM62L SoC and can currently be only found in it. Signed-off-by: T Pratham <t-pratham@ti.com> --- PS: Please note that the dmas option in dt-bindings is subject to change in future as dma driver is not finalized yet. Any updated changes will be sent in the next version of the patch. .../devicetree/bindings/crypto/ti,dthev2.yaml | 50 ++++++++++++++++++++++ MAINTAINERS | 6 +++ 2 files changed, 56 insertions(+)diff --git a/Documentation/devicetree/bindings/crypto/ti,dthev2.yaml b/Documentation/devicetree/bindings/crypto/ti,dthev2.yaml new file mode 100644 index 0000000000000000000000000000000000000000..9c871fe191ae0a3341d047d4565ec1e1bf1f21ef --- /dev/null +++ b/Documentation/devicetree/bindings/crypto/ti,dthev2.yaml
Filename matching compatible.
quoted hunk ↗ jump to hunk
@@ -0,0 +1,50 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/crypto/ti,dthev2.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: K3 SoC DTHE V2 crypto module + +maintainers: + - T Pratham <t-pratham@ti.com> + +properties: + compatible: + enum: + - ti,dthe-v2
NAK, SoC-based compatible instead.
+ + reg: + maxItems: 1 + + dmas: + items: + - description: 'AES Engine RX DMA Channel' + - description: 'AES Engine TX DMA Channel' + - description: 'SHA Engine TX DMA Channel' + + dma-names: + items: + - const: rx + - const: tx1 + - const: tx2 + +
Drop stray blank line
+required: + - compatible + - reg + - dmas + - dma-names + +additionalProperties: false + +examples: + - | +
Drop stray blank line
+ crypto: crypto@40800000 {Drop label
+ compatible = "ti,dthe-v2"; + reg = <0x00 0x40800000 0x00 0x10000>; + + dmas = <&main_bcdma 0 0xc701 0>, <&main_bcdma 0 0x4700 0>, <&main_bcdma 0 0xc700 0>;
Wrap according to coding style. Best regards, Krzysztof