Re: [PATCH v10 4/7] Coresight: Introduce a new struct coresight_path
From: kernel test robot <hidden>
Date: 2025-02-08 05:48:13
Also in:
linux-arm-msm, linux-devicetree, lkml, llvm, oe-kbuild-all
Hi Jie, kernel test robot noticed the following build warnings: [auto build test WARNING on robh/for-next] [also build test WARNING on atorgue-stm32/stm32-next linus/master v6.14-rc1 next-20250207] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jie-Gan/Coresight-Add-support-for-new-APB-clock-name/20250207-144657 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next patch link: https://lore.kernel.org/r/20250207064213.2314482-5-quic_jiegan%40quicinc.com patch subject: [PATCH v10 4/7] Coresight: Introduce a new struct coresight_path config: arm-randconfig-002-20250208 (https://download.01.org/0day-ci/archive/20250208/202502081313.JqJlff9y-lkp@intel.com/config) compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250208/202502081313.JqJlff9y-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot [off-list ref] | Closes: https://lore.kernel.org/oe-kbuild-all/202502081313.JqJlff9y-lkp@intel.com/ (local) All warnings (new ones prefixed by >>):
quoted
drivers/hwtracing/coresight/coresight-core.c:659: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Links or sources will read their existing or alloc a trace ID, if their ID
drivers/hwtracing/coresight/coresight-core.c:676: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Call this after creating the path and before enabling it. This leaves
vim +659 drivers/hwtracing/coresight/coresight-core.c
657
658 /**
> 659 * Links or sources will read their existing or alloc a trace ID, if their ID
660 * callback is set.
661 */
662 static int coresight_get_trace_id(struct coresight_device *csdev,
663 enum cs_mode mode,
664 struct coresight_device *sink)
665 {
666 if (csdev->type == CORESIGHT_DEV_TYPE_LINK && link_ops(csdev)->trace_id)
667 return link_ops(csdev)->trace_id(csdev, mode, sink);
668
669 if (csdev->type == CORESIGHT_DEV_TYPE_SOURCE && source_ops(csdev)->trace_id)
670 return source_ops(csdev)->trace_id(csdev, mode, sink);
671
672 return 0;
673 }
674
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki