[PATCH v14 07/15] PCI: endpoint: pci-ep-msi: Add MSI address/data pair mutable check
flat view
STALE624d
SUPERSEDED
From: Frank Li <Frank.Li@nxp.com>
Date: 2025-02-07 19:41:05
Also in:
imx, linux-devicetree, linux-kselftest, linux-pci, lkml
Subsystem:
pci endpoint subsystem, pci subsystem, the rest · Maintainers:
Manivannan Sadhasivam, Krzysztof Wilczyński, Bjorn Helgaas, Linus Torvalds
Revision v14 of 10 in this series.
Revisions (10)
Some MSI controller change address/data pair when irq_set_affinity(). Current PCI endpoint can't support this type MSI controller. So add flag MSI_FLAG_MUTABLE in include/linux/msi.h and check it when allocate doorbell. Signed-off-by: Frank Li <Frank.Li@nxp.com> --- change fomr v13 to v14 - bring v10 back Change from v9 to v10 - new patch --- drivers/pci/endpoint/pci-ep-msi.c | 8 ++++++++ 1 file changed, 8 insertions(+)
diff --git a/drivers/pci/endpoint/pci-ep-msi.c b/drivers/pci/endpoint/pci-ep-msi.c
index 53820744ce502..e3ec53c2fefbe 100644
--- a/drivers/pci/endpoint/pci-ep-msi.c
+++ b/drivers/pci/endpoint/pci-ep-msi.c@@ -43,6 +43,14 @@ int pci_epf_alloc_doorbell(struct pci_epf *epf, u16 num_db) dev_set_msi_domain(dev, dom); + if (!irq_domain_is_msi_parent(dom)) + return -EINVAL; + + if (!irq_domain_is_msi_immutable(dom)) { + dev_err(dev, "Can't support mutable address/data pair MSI controller\n"); + return -EINVAL; + } + msg = kcalloc(num_db, sizeof(struct pci_epf_doorbell_msg), GFP_KERNEL); if (!msg) return -ENOMEM;
--
2.34.1