RE: [PATCH v12 8/8] MAINTAINERS: Add entries for Toshiba Visconti Video Input Interface

Hello Laurent,

Thank you for your review comments.

-----Original Message-----
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Sent: Thursday, January 2, 2025 10:17 PM
To: ishikawa yuji(石川 悠司 ○ＲＤＣ□ＡＩＴＣ○ＥＡ開)
[off-list ref]
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>; Rob Herring
[off-list ref]; Krzysztof Kozlowski [off-list ref]; Conor Dooley
[off-list ref]; Sakari Ailus [off-list ref]; Hans
Verkuil [off-list ref]; iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ
□ＤＩＴ○ＯＳＴ) [off-list ref];
linux-media@vger.kernel.org; linux-kernel@vger.kernel.org;
linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org
Subject: Re: [PATCH v12 8/8] MAINTAINERS: Add entries for Toshiba Visconti
Video Input Interface

Hi Ishikawa-san,

Thank you for the patch.

On Mon, Nov 25, 2024 at 06:21:46PM +0900, Yuji Ishikawa wrote:

quoted

Added entries for visconti Video Input Interface driver, including;

Commit messages are written using the imperative mood, as if you were giving
orders to someone:

s/Added/Add/

Thank you for the advice. I'll update commit messages.

quoted

* device tree bindings
* source files
* documentation files

Signed-off-by: Yuji Ishikawa <redacted>
Reviewed-by: Nobuhiro Iwamatsu <redacted>

I would have added the MAINTAINERS entry in 1/8 with just the DT binding file,
and added more files in corresponding patches. That would be easier to review
and check if entries are missing. I don't mind much though, so if you prefer
keeping it this way:

From the next patch set, I'll update MAINTAINERS at the same time as new files are added.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

quoted

---
Changelog v2:
- no change

Changelog v3:
- added entry for driver API documentation

Changelog v4:
- added entry for header file

Changelog v5:
- no change

Changelog v6:
- update path to VIIF driver source files

Changelog v7:
- no change

Changelog v8:
- rename bindings description file

Changelog v9:
- no change

Changelog v10:
- add a separate entry of VIIF driver

Changelog v11:
- no change

Changelog v12:
- add a bindings description of CSI2RX driver

 MAINTAINERS | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS index

b878ddc99f94..b5c819e94e9b 100644

--- a/MAINTAINERS
+++ b/MAINTAINERS

@@ -23430,6 +23430,18 @@ F:

	Documentation/devicetree/bindings/media/i2c/tc358743.txt

quoted

 F:	drivers/media/i2c/tc358743*
 F:	include/media/i2c/tc358743.h

+TOSHIBA VISCONTI VIIF DRIVER
+M:	Nobuhiro Iwamatsu [off-list ref]
+M:	Yuji Ishikawa [off-list ref]
+L:	linux-media@vger.kernel.org
+S:	Maintained
+F:	Documentation/admin-guide/media/visconti-viif.*
+F:

	Documentation/devicetree/bindings/media/toshiba,visconti5-csi2rx.y
aml

quoted

+F:

	Documentation/devicetree/bindings/media/toshiba,visconti5-viif.yam
l

quoted

+F:	Documentation/userspace-api/media/v4l/metafmt-visconti-viif.rst
+F:	drivers/media/platform/toshiba/visconti/
+F:	include/uapi/linux/visconti_viif.h
+
 TOSHIBA WMI HOTKEYS DRIVER
 M:	Azael Avalos [off-list ref]
 L:	platform-driver-x86@vger.kernel.org

--
Regards,

Laurent Pinchart

Regards,
Yuji Ishikawa