Re: [PATCH v3] usb: phy: mxs: silence EPROBE_DEFER error on boot
From: Frank Li <Frank.li@nxp.com>
Date: 2025-02-03 15:40:36
Also in:
imx, linux-usb, lkml
On Mon, Feb 03, 2025 at 03:58:41PM +0900, Dominique Martinet wrote:
Use dev_err_probe to silence EPROBE_DEFER error on boot on i.MX8ULP: [ 0.127301] mxs_phy 29910000.usb-phy: can't get the clock, err=-517 Signed-off-by: Dominique Martinet <redacted> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
quoted hunk ↗ jump to hunk
Changes in v3: - add trailing newline to format string - Link to v2: https://lore.kernel.org/r/20250203-defer_usb2-v2-1-69b3a941371a@atmark-techno.com (local) Changes in v2: - removed redundant error message and now useless braces, thank you for the quick feedback! - adjusted message alignment (that was also bugging me...) - Link to v1: https://lore.kernel.org/r/20250203-defer_usb2-v1-1-2366f26462e0@atmark-techno.com (local) --- drivers/usb/phy/phy-mxs-usb.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c index 7490f1798b461c39c29bb74e1e57e0a4adce2bd7..7069dd3f4d0d9433d62d3c3b494c2f99858e1899 100644 --- a/drivers/usb/phy/phy-mxs-usb.c +++ b/drivers/usb/phy/phy-mxs-usb.c@@ -769,11 +769,9 @@ static int mxs_phy_probe(struct platform_device *pdev) return PTR_ERR(base); clk = devm_clk_get(&pdev->dev, NULL); - if (IS_ERR(clk)) { - dev_err(&pdev->dev, - "can't get the clock, err=%ld", PTR_ERR(clk)); - return PTR_ERR(clk); - } + if (IS_ERR(clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(clk), + "can't get the clock\n"); mxs_phy = devm_kzalloc(&pdev->dev, sizeof(*mxs_phy), GFP_KERNEL); if (!mxs_phy)--- base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b change-id: 20250203-defer_usb2-ee26f66a01ad Best regards, -- Dominique Martinet [off-list ref]