Thread (2 messages) 2 messages, 2 authors, 2025-01-27

Re: [PATCH v2] irqchip/irq-mvebu-icu: Fix access to msi_data from irq_domain

From: Thomas Gleixner <hidden>
Date: 2025-01-27 10:30:33
Also in: lkml, stable

On Fri, Jan 24 2025 at 09:50, Stefan Eichenberger wrote:
Previously, we incorrectly cast irq_domain->host_data directly to
Previously 'we' do nothing. The current implementation casts inconrrectly.
mvebu_icu_msi_data. However, host_data actually stores a structure of
type msi_domain_info.

This incorrect assumption caused issues such as the thermal sensors of
the CP110 platform malfunctioning. Specifically, the translation of the
SEI interrupt to IRQ_TYPE_EDGE_RISING failed, preventing proper
interrupt handling. The following error was observed:
genirq: Setting trigger mode 4 for irq 85 failed (irq_chip_set_type_parent+0x0/0x34)
armada_thermal f2400000.system-controller:thermal-sensor@70: Cannot request threaded IRQ 85

This commit resolves the issue by first casting host_data to
This commit is equally wrong as 'This patch'. See Documentation/process/
msi_domain_info and then accessing the mvebu_icu_msi_data through
msi_domain_info->chip_data.
I fixed it up for you.

Thanks,

        tglx
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help