Re: [PATCH v12 10/13] dt-bindings: display: vop2: describe constraint SoC by SoC
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-01-22 08:02:30
Also in:
dri-devel, linux-devicetree, linux-rockchip, lkml
On Tue, Jan 21, 2025 at 06:32:47PM +0800, Andy Yan wrote:
From: Andy Yan <andy.yan@rock-chips.com> As more SoCs variants are introduced, each SoC brings its own unique set of constraints, describe this constraints SoC by SoC will make things easier for adding new variant. Signed-off-by: Andy Yan <andy.yan@rock-chips.com> ---
quoted hunk ↗ jump to hunk
Changes in v12: - Only change the description method for existing SoC. Changes in v11: - Remove redundant min/maxItems constraint Changes in v10: - Move interrupt-names back to top level - Add constraint of interrupts for all platform - Add constraint for all grf phandles - Reorder some properties Changes in v9: - Drop 'vop-' prefix of interrupt-names. - Add blank line between DT properties - Remove list interrupt-names in top level Changes in v8: - Fix dt_binding_check errors - ordered by soc name - Link to the previous version: https://lore.kernel.org/linux-rockchip/6pn3qjxotdtpzucpul24yro7ppddezwuizneovqvmgdwyv2j7p@ztg4mqyiqmjf/T/#u (local) Changes in v4: - describe constraint SOC by SOC, as interrupts of rk3576 is very different from others - Drop Krzysztof's Reviewed-by, as this version changed a lot. Changes in v3: - ordered by soc name - Add description for newly added interrupt Changes in v2: - Add dt bindings .../display/rockchip/rockchip-vop2.yaml | 44 +++++++++++++------ 1 file changed, 30 insertions(+), 14 deletions(-)diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml index 2531726af306..f23939e67fd0 100644 --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml@@ -14,6 +14,7 @@ description: maintainers: - Sandy Huang <hjc@rock-chips.com> - Heiko Stuebner <heiko@sntech.de> + - Andy Yan <andyshrk@163.com> properties: compatible:@@ -120,43 +121,58 @@ allOf: properties: compatible: contains: - const: rockchip,rk3588-vop + enum: + - rockchip,rk3566-vop + - rockchip,rk3568-vop then: properties: clocks: - minItems: 7 + minItems: 5
I don't see any changes comparing to original binding. At least not for clocks.
+
clock-names:
- minItems: 7
+ minItems: 5
+
+ interrupts:
+ maxItems: 1This is useless and not explained. Best regards, Krzysztof