Re: [PATCH 1/3] dt-bindings: gpu: mali-bifrost: Add compatible for MT8370 SoC
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-01-18 16:01:28
Also in:
dri-devel, linux-devicetree, linux-mediatek, lkml
On Thu, Jan 16, 2025 at 03:25:57PM +0100, Louis-Alexis Eyraud wrote:
This commit adds a compatible for the MediaTek MT8370 SoC, with an
Please do not use "This commit/patch/change", but imperative mood. See longer explanation here: https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
integrated ARM Mali G57 MC2 GPU (Valhall-JM, dual core).
Anyway, your commit msg explains "what" which is obvious. Say something not obvious - e.g. not compatible with 8192? Why not?
quoted hunk ↗ jump to hunk
Signed-off-by: Louis-Alexis Eyraud <redacted> --- Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml index 735c7f06c24e632ab738d062f15378f754c8adaf..6f6211950bb495fa6bfcdfe8d1e27e5ce7aeeae0 100644 --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml@@ -37,6 +37,7 @@ properties: - enum: - mediatek,mt8188-mali - mediatek,mt8192-mali + - mediatek,mt8370-mali - const: arm,mali-valhall-jm # Mali Valhall GPU model/revision is fully discoverable
Best regards, Krzysztof