Re: [PATCH v3 1/5] dt-bindings: display: Add Apple pre-DCP display controller
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-01-13 08:59:02
Also in:
asahi, dri-devel, linux-devicetree, lkml
On Sun, Jan 12, 2025 at 09:43:48PM +0100, Sasha Finkelstein wrote: + ports:
+ $ref: /schemas/graph.yaml#/properties/ports
+
+ properties:
+ port@0:
+ $ref: /schemas/graph.yaml#/properties/port
+ description: Input port. Always connected to the primary controller
+
+ port@1:
+ $ref: /schemas/graph.yaml#/properties/port
+ description: Output MIPI DSI port to the panel
+
+ required:
+ - port@0
+ - port@1
+
+required:
+ - compatible
+ - reg
+ - ports
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ dsi@228200000 {
+ compatible = "apple,t8103-display-pipe-mipi", "apple,h7-display-pipe-mipi";
+ reg = <0x28200000 0xc000>;This looks not matching unit address.
+ power-domains = <&ps_dispdfr_mipi>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ #address-cells = <1>;
+ #size-cells = <0>;Make the example complete, so you will see that address/size cells are unnecessary here or, if you really have more than one endpoint, they are supposed to be here.
quoted hunk ↗ jump to hunk
+ }; + + port@1 { + reg = <1>; + #address-cells = <1>; + #size-cells = <0>; + }; + }; + }; +...diff --git a/Documentation/devicetree/bindings/display/apple,h7-display-pipe.yaml b/Documentation/devicetree/bindings/display/apple,h7-display-pipe.yaml new file mode 100644 index 0000000000000000000000000000000000000000..dc07edccb437b221ea9772b9356e1896326aa7da --- /dev/null +++ b/Documentation/devicetree/bindings/display/apple,h7-display-pipe.yaml@@ -0,0 +1,88 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/apple,h7-display-pipe.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Apple pre-DCP display controller + +maintainers: + - Sasha Finkelstein <fnkl.kernel@gmail.com> + +description: + A secondary display controller used to drive the "touchbar" on + certain Apple laptops. + +properties: + compatible: + items: + - enum: + - apple,t8112-display-pipe + - apple,t8103-display-pipe + - const: apple,h7-display-pipe + + reg: + maxItems: 2 + + reg-names: + items: + - const: be + description: Primary register block, controls planes and blendinga
Description goes to 'reg:' field, just like I asked last time.
+ - const: fe + description: + Contains other configuration registers like interrupt + and FIFO control + + power-domains: + description: + Phandles to pmgr entries that are needed for this controller to turn on. + Aside from that, their specific functions are unknown + maxItems: 2 + + interrupts:
Same comments as before - list and describe the items. Best regards, Krzysztof