Thread (10 messages) 10 messages, 3 authors, 2025-01-14

Re: [PATCH v2 1/4] dt-bindings: clock: convert stm32 rcc bindings to json-schema

From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-01-11 09:25:48
Also in: linux-clk, linux-devicetree, lkml

On Thu, Jan 09, 2025 at 10:18:28PM +0100, Dario Binacchi wrote:
+maintainers:
+  - Dario Binacchi [off-list ref]
+
+description: |
+  The RCC IP is both a reset and a clock controller.
+  The reset phandle argument is the bit number within the RCC registers bank,
+  starting from RCC base address.
+
+properties:
+  compatible:
+    oneOf:
+      - items:
+          - const: st,stm32f42xx-rcc
+          - const: st,stm32-rcc
+      - items:
+          - enum:
+              - st,stm32f469-rcc
+          - const: st,stm32f42xx-rcc
+          - const: st,stm32-rcc
+      - items:
+          - const: st,stm32f746-rcc
Why this isn't just part of enum with first group/list? Different
groups/lists are for different fallbacks and I am pretty sure fallback
is the same.
+          - const: st,stm32-rcc
+      - items:
+          - enum:
+              - st,stm32f769-rcc
+          - const: st,stm32f746-rcc
+          - const: st,stm32-rcc
+      - items:
+          - const: st,stm32h743-rcc
Same here.

Rest looks good, so with combining entries above:

Reviewed-by: Krzysztof Kozlowski <redacted>

Best regards,
Krzysztof

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help