Thread (16 messages) 16 messages, 3 authors, 2025-01-07

Re: [PATCH] pinctrl: sunxi: Use minimal debouncing period as default

From: Paul Kocialkowski <paulk@sys-base.io>
Date: 2025-01-07 11:56:11
Also in: linux-sunxi, lkml

Hi,

Le Tue 17 Dec 24, 14:58, Maxime Ripard a écrit :
On Tue, Dec 17, 2024 at 02:41:36PM +0100, Linus Walleij wrote:
quoted
On Tue, Nov 19, 2024 at 3:43 PM Maxime Ripard [off-list ref] wrote:
quoted
[Paul]
quoted
The pinctrl code supports an input-debounce device-tree property to set
a specific debouncing period and choose which clock source is most
relevant. However the property is specified in microseconds, which is
longer than the minimal period achievable from the high-frequency
oscillator without a pre-scaler.
That can be fixed by introducing a new property with a ns resolution.
Perhaps, but I think a setting of 0 should just yield the minimum
resolution in this case, as apparently the debounce cannot be
turned off? This would also make sense to expose for
gpiod_set_debounce() as explained in my other mail.
Yeah, if we want to have 0 == lowest resolution, I'm all for it.
I agree that it would be easier and less confusing than introducing a new
property just to have a finer resolution.

I could craft a patch in that direction then, with a mention about it in the
bindings.

Cheers,

Paul

-- 
Paul Kocialkowski,

Independent contractor - sys-base - https://www.sys-base.io/
Free software developer - https://www.paulk.fr/

Expert in multimedia, graphics and embedded hardware support with Linux.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help