Re: [PATCH v2 3/3] mfd: syscon: Allow syscon nodes without a "syscon" compatible

On 17/12/2024 19:11, Rob Herring (Arm) wrote:

of_syscon_register_regmap() was added for nodes which need a custom
regmap setup. It's not really correct for those nodes to claim they are
compatible with "syscon" as the default handling likely doesn't work in
those cases. If device_node_get_regmap() happens to be called first,
then of_syscon_register() will be called and an incorrect regmap will be
created (barring some other error). That may lead to unknown results in
the worst case. In the best case, of_syscon_register_regmap() will fail
with -EEXIST. This problem remains unless these cases drop "syscon" (an
ABI issue) or we exclude them using their specific compatible. ATM,
there is only one user: "google,gs101-pmu"

Reviewed-by: Krzysztof Kozlowski <redacted>

Best regards,
Krzysztof