Re: [PATCH 2/4] dt-bindings: mfd: syscon: allow two reg regions for gs101-pmu
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2024-12-22 14:24:13
Also in:
linux-devicetree, linux-samsung-soc, lkml
On 13/12/2024 17:44, Peter Griffin wrote:
To avoid dtschema warnings allow google,gs101-pmu to have two reg regions. Signed-off-by: Peter Griffin <peter.griffin@linaro.org> --- I don't really like this patch, but also didn't want to submit the series with a dtschema warning ;-) Possibly a better solution is when Robs patch `mfd: syscon: Allow syscon nodes without a "syscon" compatible` [1]
PMU which spans over two blocks is not a simple syscon. These would be two syscon devices. If you request regmap from such syscon, which regmap you get? I am not sure whether the PMU is really split here. Usually the main PMU was only one and additional blocks called PMU were somehow specialized per each IP block. Maybe you have here two devices, maybe only one. If it is only one, then it is not a syscon anymore, IMO. Best regards, Krzysztof