Thread (20 messages) 20 messages, 6 authors, 2025-01-03

Re: [PATCH v10 1/4] media: dt-bindings: update clocks for sc7280-camss

From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Date: 2024-12-17 16:12:38
Also in: linux-arm-msm, linux-devicetree, linux-media, lkml

On 17/12/2024 14:10, Krzysztof Kozlowski wrote:
On 17/12/2024 15:06, Vikram Sharma wrote:
quoted
This patch change clock names to make it consistent with
existing platforms as gcc_cam_hf_axi -> gcc_axi_hf.
This also adds gcc_axi_sf and remove gcc_camera_ahb.
Don't combine ABI changes with some less important things.

You miss here explanation why doing the ABI change in the first place.
Without that explanation I find it rather churn. But anyway, reason for
ABI break and impact should be documented in commit msg.
quoted
Signed-off-by: Vikram Sharma <redacted>
---
Best regards,
Krzysztof
This change should be fine since we haven't committed and upstream dtsi, 
so there's no ABI to break yet.

Agree the cover letter should have been explicit in explaining.

---
bod
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help