Re: [PATCH 1/3] mfd: syscon: Fix race in device_node_get_regmap()
From: Krzysztof Kozlowski <hidden>
Date: 2024-12-12 10:21:07
Also in:
lkml
On 11/12/2024 21:57, Rob Herring (Arm) wrote:
It is possible for multiple, simultaneous callers calling
device_node_get_regmap() with the same node to fail to find an entry in
the syscon_list. There is a period of time while the first caller is
calling of_syscon_register() that subsequent callers also fail to find
an entry in the syscon_list and then call of_syscon_register() a second
time.
Fix this by keeping the lock held until after of_syscon_register()
completes and adds the node to syscon_list. Convert the spinlock to a
mutex as many of the functions called in of_syscon_register() may sleep.
Fixes: bdb0066df96e ("mfd: syscon: Decouple syscon interface from platform devices")
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>Tested on arm64: Qualcomm SM8450 Tested on armv7: Exynos5422 Tested-by: Krzysztof Kozlowski <redacted> Best regards, Krzysztof