Re: [PATCH 09/10] drm/sti: hdmi: use eld_mutex to protect access to connector->eld
From: Raphaël Gallais-Pou <rgallaispou@gmail.com>
Date: 2024-12-02 15:03:48
Also in:
amd-gfx, dri-devel, intel-gfx, intel-xe, linux-arm-msm, linux-samsung-soc, lkml
Le 01/12/2024 à 00:55, Dmitry Baryshkov a écrit :
Reading access to connector->eld can happen at the same time the drm_edid_to_eld() updates the data. Take the newly added eld_mutex in order to protect connector->eld from concurrent access. Signed-off-by: Dmitry Baryshkov <redacted>
Hi Dmitry, Acked-by: Raphael Gallais-Pou <rgallaispou@gmail.com> Thanks, Raphaël
quoted hunk ↗ jump to hunk
--- drivers/gpu/drm/sti/sti_hdmi.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c index 847470f747c0efad61c2ebdc3fb3746a7a13a863..3c8f3532c79723e7b1a720c855c90e40584cc6ca 100644 --- a/drivers/gpu/drm/sti/sti_hdmi.c +++ b/drivers/gpu/drm/sti/sti_hdmi.c@@ -1225,7 +1225,9 @@ static int hdmi_audio_get_eld(struct device *dev, void *data, uint8_t *buf, size struct drm_connector *connector = hdmi->drm_connector; DRM_DEBUG_DRIVER("\n"); + mutex_lock(&connector->eld_mutex); memcpy(buf, connector->eld, min(sizeof(connector->eld), len)); + mutex_unlock(&connector->eld_mutex); return 0; }