Re: [PATCH v4 15/16] KVM: selftests: Use canonical $(ARCH) paths for KVM selftests directories
From: Claudio Imbrenda <imbrenda@linux.ibm.com>
Date: 2024-11-28 08:26:19
Also in:
kvm, kvm-riscv, kvmarm, linux-riscv, lkml
On Wed, 27 Nov 2024 16:55:46 -0800 Sean Christopherson [off-list ref] wrote:
Use the kernel's canonical $(ARCH) paths instead of the raw target triple for KVM selftests directories. KVM selftests are quite nearly the only place in the entire kernel that using the target triple for directories, tools/testing/selftests/drivers/s390x being the lone holdout. Using the kernel's preferred nomenclature eliminates the minor, but annoying, friction of having to translate to KVM's selftests directories, e.g. for pattern matching, opening files, running selftests, etc. Opportunsitically delete file comments that reference the full path of the file, as they are obviously prone to becoming stale, and serve no known purpose. Signed-off-by: Sean Christopherson <seanjc@google.com> ---
just one minor nit [...]
quoted hunk ↗ jump to hunk
diff --git a/tools/testing/selftests/kvm/include/x86_64/svm_util.h b/tools/testing/selftests/kvm/include/x86/svm_util.h similarity index 94% rename from tools/testing/selftests/kvm/include/x86_64/svm_util.h rename to tools/testing/selftests/kvm/include/x86/svm_util.h index 044f0f872ba9..b74c6dcddcbd 100644 --- a/tools/testing/selftests/kvm/include/x86_64/svm_util.h +++ b/tools/testing/selftests/kvm/include/x86/svm_util.h@@ -1,8 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ /* - * tools/testing/selftests/kvm/include/x86_64/svm_utils.h
this line clearly has to go ^
- * Header for nested SVM testing
but I think this one can stay? ^ regardless, for the s390 part: Acked-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
- * * Copyright (C) 2020, Red Hat, Inc. */
[...]