Re: [Upstream] [PATCH 09/15] arm64: dts: imx8mm: move bulk of rtc properties to carrierboards
From: Teresa Remmet <hidden>
Date: 2024-11-27 10:34:26
Also in:
imx, linux-devicetree, lkml
Hello Andrej, Am Montag, dem 25.11.2024 um 09:18 +0100 schrieb Andrej Picej:
quoted hunk ↗ jump to hunk
From: Yannic Moog <redacted> Move properties from SoM's dtsi to carrierboard's dts as they are actually defined by the carrier board design. Signed-off-by: Yannic Moog <redacted> Signed-off-by: Andrej Picej <redacted> --- arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dts | 4 ++++ arch/arm64/boot/dts/freescale/imx8mm-phycore-som.dtsi | 4 ---- arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l.dts | 4 ++++ 3 files changed, 8 insertions(+), 4 deletions(-)diff --git a/arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dts b/arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dts index 7aaf705c7e47..f5f503c3c6b9 100644--- a/arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dts +++ b/arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dts@@ -221,6 +221,10 @@ &pcie_phy {/* RTC */ &rv3028 { + interrupt-parent = <&gpio1>; + interrupts = <3 IRQ_TYPE_LEVEL_LOW>; + pinctrl-0 = <&pinctrl_rtc>;
You should also move the pinctrl settings to the carrier boards. As the pin can be used differently and should not be defined by the SoM. Thanks, Teresa
quoted hunk ↗ jump to hunk
+ pinctrl-names = "default"; aux-voltage-chargeable = <1>; trickle-resistor-ohms = <3000>; wakeup-source;diff --git a/arch/arm64/boot/dts/freescale/imx8mm-phycore-som.dtsib/arch/arm64/boot/dts/freescale/imx8mm-phycore-som.dtsi index cced82226c6d..fdfe28780d6f 100644--- a/arch/arm64/boot/dts/freescale/imx8mm-phycore-som.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mm-phycore-som.dtsi@@ -301,10 +301,6 @@ eeprom@51 {/* RTC */ rv3028: rtc@52 { compatible = "microcrystal,rv3028"; - interrupts = <3 IRQ_TYPE_LEVEL_LOW>; - interrupt-parent = <&gpio1>; - pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_rtc>; reg = <0x52>; }; };diff --git a/arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l.dtsb/arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l.dts index c9bf4ac254bb..b7b18d5a4f68 100644--- a/arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l.dts +++ b/arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l.dts@@ -215,6 +215,10 @@ &pwm4 {/* RTC */ &rv3028 { + interrupt-parent = <&gpio1>; + interrupts = <3 IRQ_TYPE_LEVEL_LOW>; + pinctrl-0 = <&pinctrl_rtc>; + pinctrl-names = "default"; aux-voltage-chargeable = <1>; trickle-resistor-ohms = <3000>; wakeup-source;
-- PHYTEC Messtechnik GmbH | Barcelona-Allee 1 | 55129 Mainz, Germany Geschäftsführer: Dipl.-Ing. Michael Mitezki, Dipl.-Ing. Bodo Huber, Dipl.-Ing. (FH) Markus Lickes | Handelsregister Mainz HRB 4656 | Finanzamt Mainz | St.Nr. 26/665/00608, DE 149059855