Thread (19 messages) 19 messages, 7 authors, 2025-01-12

Re: [PATCH v2 1/5] dt-bindings: display: Add Apple pre-DCP display controller bindings

From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2024-11-26 16:54:09
Also in: asahi, dri-devel, linux-devicetree, lkml

On 26/11/2024 17:46, Krzysztof Kozlowski wrote:
quoted
+
+  reg:
+    maxItems: 1
+
+  max-brightness: true
+
+  port: true
No, these cannot be true without definition. Again, please open existing
bindings and use them as example. You probably miss here some reference,
but max-brightness for panel is a bit confusing. I asked already and did
not get answer: isn't this backlight property? What is this device -
backlight or panel? If panel, then what bus?
You responded to my comment in exactly the same moment you sent this
patchset which gives me around 0 seconds to reply to your comment.

Give reviewers some time if you disagree with them, otherwise I find
wrong sending next version immediately.

Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help