Re: [PATCH 1/5] dt-bindgins: display: Add Apple pre-DCP display controller bindings

On 2024/11/25 23:53, Krzysztof Kozlowski wrote:

On 25/11/2024 15:14, Hector Martin wrote:

quoted

quoted

quoted

+
+  "#address-cells":
+    const: 1
+
+  "#size-cells":
+    const: 0
+
+additionalProperties: true

This cannot be true. Must be false.

quoted

+
+required:
+  - compatible
+  - reg
+  - interrupts

This goes before additionalProperties.

Missing example: that's a strong NAK and prove that this could not be
even tested.

Do you see any device schema without example? No. Do not develop things
differently, Apple is not unique, special or exceptional.

Krzysztof, it is entirely possible to express this same feedback without
being condescending and rude. I'm pretty sure you can do better than this.

Please kindly trim the replies from unnecessary context. It makes it
much easier to find new content.

Noted.
 > Instead of patronizing, note that this was just pure observation - this

was done entirely than other bindings, which should be taken as an
example. Or example-schema should be taken as example... Pointing out
issues and inconsistencies is not rude or condescending. Basically now
you are condescending people's feedback which further restricts review
process allowing comments which you approve.

No, that was certainly not pure observation. The observation is that the
schema was inconsistent with other schemas, and was missing an example.
The way you *expressed* that observation was unnecessarily rude and
condescending, both in tone and message. Usage of "NAK" is strongly
confrontational and discouraging to newcomers, and completely
inappropriate here because the intent of the patch is clearly fine and
it just needs some style and procedural issues fixed. "Do you ...? No."
wording is condescending, like you're talking down to a child. The
gratuitous Apple reference is completely unnecessary, implying we're
attempting to be a special snowflake in any (non-technically-justified)
way, never mind that none of us works nor has any professional
relationship with Apple.

Your observation and feedback could have been conveyed much more
appropriately, kindly, and effectively, such as:

==
The schema is missing an example. Examples are required for schemas, as
they are part of how the schema is tested by the automated tooling.
Please see other schemas and `example-schema.yaml` for examples on how
to do this, and `writing-schema.rst` for more information and how to run
the checks.
==

- Hector