Re: [PATCH v5 16/16] net: stmmac: platform: Fix PTP clock rate reading
From: Jan Petrous <jan.petrous@oss.nxp.com>
Date: 2024-11-21 17:13:05
Also in:
imx, linux-arm-msm, linux-devicetree, lkml, netdev
On Thu, Nov 21, 2024 at 08:45:20AM +0100, Paolo Abeni wrote:
On 11/19/24 16:00, Jan Petrous (OSS) wrote:quoted
From: "Jan Petrous (OSS)" <jan.petrous@oss.nxp.com> The stmmac driver supports many vendors SoCs using Synopsys-licensed Ethernet controller IP. Most of these vendors reuse the stmmac_platform codebase, which has a potential PTP clock initialization issue. The PTP clock rate reading might require ungating what is not provided. Fix the PTP clock initialization by enabling it immediately. Signed-off-by: Jan Petrous (OSS) <jan.petrous@oss.nxp.com>Side, process-related note: it would be great if you could trim the patch series below 16 (currently off-by-one): https://elixir.bootlin.com/linux/v6.11.8/source/Documentation/process/maintainer-netdev.rst#L14 This patch looks like an independent fix, possibly worth the 'net' tree. If so, please submit this patch separately, including a suitable fixes tag and including the 'net' keyword in the patch subj prefix.
Yeh, I also was a bit worried about patchwork fail check on patch series size. Thanks for your hint, I will remove this PTP clock rate patch from the series and resend it to the 'net' tree with fixes tag. BR. /Jan