Re: [PATCH] pinctrl: samsung: Fix irq handling if an error occurs in exynos_irq_demux_eint16_31()
From: Christophe JAILLET <hidden>
Date: 2024-11-18 17:49:51
Also in:
kernel-janitors, linux-gpio, linux-samsung-soc, lkml
Le 18/11/2024 à 10:40, André Draszik a écrit :
On Sun, 2024-11-17 at 13:03 +0100, Christophe JAILLET wrote:quoted
chained_irq_enter(() should be paired with a corresponding chained_irq_exit(). Here, if clk_enable() fails, a early return occurs and chained_irq_exit() is not called. Add a new label and a goto for fix it. Fixes: f9c744747973 ("pinctrl: samsung: support a bus clock") Signed-off-by: Christophe JAILLET <redacted> --- Compile tested only. Review with care, irq handling is sometimes tricky...Well spotted, thanks. It looks like there is a similar problem in exynos_irq_request_resources() in same file. It should likely call gpiochip_unlock_as_irq() if clk_enable() failed.
Agreed.
Care to fix that as well?
NP, I'll send a patch. CJ
That said, Reviewed-by: André Draszik <andre.draszik@linaro.org> Cheers, Andre'