Re: [PATCH] drm/imx/dcss: include drm/drm_bridge.h header
From: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
Date: 2024-11-04 12:11:02
Also in:
dri-devel, imx, lkml
Hi Arnd, On Mon, Oct 28, 2024 at 04:35:07PM +0000, Arnd Bergmann wrote:
From: Arnd Bergmann <arnd@arndb.de>
Compile-testing random configurations leads to failures in
dcss-kms.c from a missing declaration:
drivers/gpu/drm/imx/dcss/dcss-kms.c:95:8: error: use of undeclared identifier 'drm_bridge_attach'
95 | ret = drm_bridge_attach(encoder, bridge, NULL,
| ^
drivers/gpu/drm/imx/dcss/dcss-kms.c:96:5: error: use of undeclared identifier 'DRM_BRIDGE_ATTACH_NO_CONNECTOR'
96 | DRM_BRIDGE_ATTACH_NO_CONNECTOR);
| ^
Include the header directly.
Fixes: 004555a18d57 ("drm/imx/dcss: Allow build with COMPILE_TEST=y")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>Reviewed-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com> Unfortunately, it appears I lost drm-misc push rights. Maxime, Thomas or Ville, can you help push this? Thanks, Laurentiu
quoted hunk ↗ jump to hunk
--- drivers/gpu/drm/imx/dcss/dcss-kms.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/gpu/drm/imx/dcss/dcss-kms.c b/drivers/gpu/drm/imx/dcss/dcss-kms.c index 3ec721afc30c..63a335c62296 100644 --- a/drivers/gpu/drm/imx/dcss/dcss-kms.c +++ b/drivers/gpu/drm/imx/dcss/dcss-kms.c@@ -5,6 +5,7 @@ #include <drm/drm_atomic.h> #include <drm/drm_atomic_helper.h> +#include <drm/drm_bridge.h> #include <drm/drm_bridge_connector.h> #include <drm/drm_client_setup.h> #include <drm/drm_drv.h>-- 2.39.5