Thread (29 messages) 29 messages, 2 authors, 2024-10-31

Re: [PATCH v2 01/11] scsi: ufs: exynos: Allow UFS Gear 4

From: Peter Griffin <peter.griffin@linaro.org>
Date: 2024-10-30 12:05:37
Also in: linux-devicetree, linux-samsung-soc, linux-scsi, lkml

Hi Tudor,

On Wed, 30 Oct 2024 at 08:04, Tudor Ambarus [off-list ref] wrote:


On 10/25/24 2:14 PM, Peter Griffin wrote:
quoted
UFS Gear 4 offers faster speeds, and better power usage so lets
enable it.

Currently ufshcd_init_host_params() sets UFS_HS_G3 as a default,
so even if the device supports G4 we end up negotiating down to
G3.

For SoCs like gs101 which have a UFS major controller version
of 3 or above advertise Gear 4. This then allows a Gear 4 link
on Pixel 6.

For earlier controller versions keep the current default behaviour
of reporting G3.

Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>

some nits/personal preferences below, no need to address them
As I'm re-spinning anyways I'll update it like you suggest.

Peter.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help