On 28 October 2024 17:12:56 CET, Jakub Kicinski [off-list ref] wrote:

On Sat, 19 Oct 2024 18:49:24 +0100 David Woodhouse wrote:

quoted

quoted

Yes please and thank you! We gotta straighten it out before 
the merge window.  

Hm, as I (finally) come to do that, I realise that many of the others
defined in drivers/ptp/Kconfig are also 'default y'. Which is only
really 'default PTP_1588_CLOCK' in practice since they all depend on
that.

AFAICT nothing defaulted to enabled since 2017, so I'd chalk it up
to us getting better at catching mistakes over time.

quoted

Most importantly, PTP_1588_CLOCK_KVM is 'default y'. And that one is
fundamentally broken (at least in the presence of live migration if
guests care about their clock suddenly being wrong) which is why it's
being superseded by the new VMCLOCK thing. We absolutely don't want to
leave the _KVM one enabled by default and not its _VMCLOCK replacement.

You can default to .._CLOCK_KVM, and provide the explanation in
the commit message and Kconfig help.

That works for me. But now it's my vacation time so it'll be at least Thursday before I can do that. I'll offer a preemptive Acked-by: David Woodhouse [off-list ref] to anyone who beats me to it :)