Re: [PATCH 4/7] iio: light: veml6030: simplify code in write_event_config callback
From: Jonathan Cameron <jic23@kernel.org>
Date: 2024-10-26 12:26:40
Also in:
chrome-platform, linux-iio, lkml
On Thu, 24 Oct 2024 11:11:26 +0200 Julien Stephan [off-list ref] wrote:
iio_ev_state_store is actually using kstrtobool to check user input, then gives the converted boolean value to the write_event_config callback. Remove useless code in write_event_config callback. Signed-off-by: Julien Stephan <jstephan@baylibre.com>
Applied. After patch 7 this will include a shift of a bool which is a little unusual but valid C.
quoted hunk ↗ jump to hunk
--- drivers/iio/light/veml6030.c | 3 --- 1 file changed, 3 deletions(-)diff --git a/drivers/iio/light/veml6030.c b/drivers/iio/light/veml6030.c index d6f3b104b0e6be8e095a1ad9f20acb81ce492630..95751c1015909cd80543a559673f435d1a168f68 100644 --- a/drivers/iio/light/veml6030.c +++ b/drivers/iio/light/veml6030.c@@ -826,9 +826,6 @@ static int veml6030_write_interrupt_config(struct iio_dev *indio_dev, int ret; struct veml6030_data *data = iio_priv(indio_dev); - if (state < 0 || state > 1) - return -EINVAL; - ret = veml6030_als_shut_down(data); if (ret < 0) { dev_err(&data->client->dev,