Re: [PATCH v4 4/9] PCI: imx6: Correct controller_id generation logic for i.MX7D
From: Manivannan Sadhasivam <hidden>
Date: 2024-10-22 16:55:55
Also in:
imx, linux-devicetree, linux-pci, lkml
On Tue, Oct 15, 2024 at 04:33:28PM +0800, Richard Zhu wrote:
quoted hunk ↗ jump to hunk
i.MX7D only has one PCIe controller, so controller_id should always be 0. The previous code is incorrect although yielding the correct result. Fix by removing IMX7D from the switch case branch. Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> Reviewed-by: Frank Li <Frank.Li@nxp.com> --- drivers/pci/controller/dwc/pci-imx6.c | 1 - 1 file changed, 1 deletion(-)diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index 2ae6fa4b5d32..ca8714c625fe 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c@@ -1338,7 +1338,6 @@ static int imx_pcie_probe(struct platform_device *pdev) switch (imx_pcie->drvdata->variant) { case IMX8MQ: case IMX8MQ_EP: - case IMX7D: if (dbi_base->start == IMX8MQ_PCIE2_BASE_ADDR)
This is just *wrong*. You cannot hardcode the MMIO address in the driver. Even though this code is old, you should fix it instead of building on top of it. - Mani -- மணிவண்ணன் சதாசிவம்