Re: [PATCH v4] watchdog: stm32_iwdg: Add pretimeout support
From: Marek Vasut <marex@denx.de>
Date: 2024-09-24 13:13:39
Also in:
linux-watchdog
On 9/5/24 3:12 PM, Marek Vasut wrote:
On 6/23/24 8:18 PM, Marek Vasut wrote:quoted
On 4/15/24 3:48 PM, Marek Vasut wrote:quoted
The STM32MP15xx IWDG adds registers which permit this IP to generate pretimeout interrupt. This interrupt can also be used to wake the CPU from suspend. Implement support for generating this interrupt and let userspace configure the pretimeout. In case the pretimeout is not configured by user, set pretimeout to 3/4 of the WDT timeout cycle. Reviewed-by: Clément Le Goffic <redacted> Tested-by: Clément Le Goffic <redacted> Signed-off-by: Marek Vasut <marex@denx.de> --- Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> Cc: Guenter Roeck <linux@roeck-us.net> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> Cc: Wim Van Sebroeck <wim@linux-watchdog.org> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-stm32@st-md-mailman.stormreply.com Cc: linux-watchdog@vger.kernel.org --- V2: - Subtract the pretimeout value from timeout value before writing it into the IWDG pretimeout register, because the watchdog counter register is counting down, and the pretimeout interrupt triggers when watchdog counter register matches the pretimeout register content. - Set default pretimeout to 3/4 of timeout . V3: - Use dev instead of pdev->dev - Swap order of ret/return 0 - Split this from the DT changes, which are orthogonal - Uh, this patch got stuck in upstreaming queue, sorry V4: - Update commit message to match V2 default pretimeout to 3/4 - Add RB/TB from ClémentHi, Are there still any open topics with this patch ?Anything ?
Can this be pulled via the stm32 SoC tree ?