Re: [PATCH v2 1/6] dt-bindings: clock: imx8m-anatop: support spread spectrum clocking
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2024-09-29 19:45:14
Also in:
imx, linux-clk, linux-devicetree, lkml
On Sun, Sep 29, 2024 at 07:27:11PM +0200, Dario Binacchi wrote:
quoted hunk ↗ jump to hunk
The patch adds the DT bindings for enabling and tuning spread spectrum clocking generation. Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> --- Changes in v2: - Add "allOf:" and place it after "required:" block, like in the example schema. - Move the properties definition to the top-level. - Drop unit types as requested by the "make dt_binding_check" command. .../bindings/clock/fsl,imx8m-anatop.yaml | 45 +++++++++++++++++++ 1 file changed, 45 insertions(+)diff --git a/Documentation/devicetree/bindings/clock/fsl,imx8m-anatop.yaml b/Documentation/devicetree/bindings/clock/fsl,imx8m-anatop.yaml index bbd22e95b319..a142c04fef00 100644 --- a/Documentation/devicetree/bindings/clock/fsl,imx8m-anatop.yaml +++ b/Documentation/devicetree/bindings/clock/fsl,imx8m-anatop.yaml@@ -33,11 +33,56 @@ properties: '#clock-cells': const: 1 + fsl,ssc-clocks:
<form letter> This is a friendly reminder during the review process. It seems my or other reviewer's previous comments were not fully addressed. Maybe the feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. </form letter> You just ignored my email and never cared to respond. Implement the feedback. Best regards, Krzysztof