Re: [PATCH v3 3/6] gpio: aspeed: Create llops to handle hardware access
From: Billy Tsai <hidden>
Date: 2024-09-19 06:12:52
Also in:
linux-aspeed, linux-devicetree, linux-gpio, lkml
From: Billy Tsai <hidden>
Date: 2024-09-19 06:12:52
Also in:
linux-aspeed, linux-devicetree, linux-gpio, lkml
Hi Andrew, I will add the following change on the next patch: 1. Add `privilege_ctrl` and `privilege_init` callback 2. Use `bool aspeed_gpio_support_copro()` api to replace the `cmd_source_supoort` flag 3. Add the `dcache_require` flag and move the dcache usage into the `reg_bit_set` callback 4. `reg_bits_set` -> `reg_bit_set` and `reg_bits_read` -> `reg_bits_get` 5. `bool copro = 0` -> `bool copro = false` 6. if (!gpio->config->llops->reg_bit_set || !gpio->config->llops->reg_bits_get) return -EINVAL; Thanks for your comments.