Thread (6 messages) 6 messages, 4 authors, 2024-10-09

Re: [PATCH] clk: rockchip: fix finding of maximum clock ID

From: Yao Zi <hidden>
Date: 2024-09-16 07:32:02
Also in: linux-clk, linux-rockchip, lkml

On Sat, Sep 14, 2024 at 08:48:53AM +0200, Sebastian Reichel wrote:
Hi,

On Thu, Sep 12, 2024 at 01:32:05PM GMT, Yao Zi wrote:
quoted
If an ID of a branch's child is greater than current maximum, we should
set new maximum to the child's ID, instead of its parent's.

Fixes: 2dc66a5ab2c6 ("clk: rockchip: rk3588: fix CLK_NR_CLKS usage")
Signed-off-by: Yao Zi <redacted>
---
Reviewed-by: Sebastian Reichel <redacted>

oops, good catch. Note, that the function returns the correct value
for RK3588, since the clocks with the highest IDs are of GATE_LINK
type and do not have their child field set.
yes, but it does hit me when working for rk3528 clock controller unit.
I have not checked all
the Rockchip SoCs converted for 6.12, so I suggest sending this as
fixes material for 6.12.
I have done a rough check and think no code in 6.11 release is affected.
Greetings,

-- Sebastian
Cheers,
Yao Zi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help