Thread (7 messages) 7 messages, 2 authors, 2024-09-11

Re: [PATCH v5 2/3] tty: serial: samsung: Fix A7-A11 serial earlycon SError

From: Andi Shyti <andi.shyti@kernel.org>
Date: 2024-09-11 06:57:59
Also in: asahi, linux-samsung-soc, linux-serial, lkml

Hi Nick,

On Wed, Sep 11, 2024 at 01:02:12PM GMT, Nick Chan wrote:
Apple's earlier SoCs, like A7-A11, requires 32-bit writes for the serial
port. Otherwise, a SError happens when writing to UTXH (+0x20). This only
manifested in earlycon as reg-io-width in the device tree is consulted
for normal serial writes.

Change the iotype of the port to UPIO_MEM32, to allow the serial port to
function on A7-A11 SoCs. This change does not appear to affect Apple M1 and
above.

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Neal Gompa <neal@gompa.dev>
Tested-by: Janne Grunau <j@jannau.net>
Signed-off-by: Nick Chan <redacted>
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>

Andi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help