Re: [PATCH net-next v7 7/7] net: stmmac: silence FPE kernel logs
From: Vladimir Oltean <olteanv@gmail.com>
Date: 2024-09-04 16:00:34
Also in:
lkml, netdev
On Wed, Sep 04, 2024 at 05:21:22PM +0800, Furong Xu wrote:
ethtool --show-mm can get real-time state of FPE. Those kernel logs should keep quiet. Signed-off-by: Furong Xu <redacted> ---
I don't have a stmmac-based setup to judge in person. But to me, these still look too chatty, for being things that user space can always query through netlink. 1070 » netdev_info(priv->dev, "configured EST\n"); 1090 » netdev_info(priv->dev, "disabled FPE\n"); Also, they don't seem to be balanced. We don't have "disabled EST" and "enabled FPE"?! I wonder if "disabled FPE" is actually a typo and should have been "disabled EST"? What do you think, should these also be suppressed / deleted?