Thread (13 messages) 13 messages, 9 authors, 2024-09-03

Re: [PATCH v2] drivers: spi: Insert the missing pci_dev_put()before return

From: Mark Brown <broonie@kernel.org>
Date: 2024-09-02 11:48:43
Also in: linux-spi, lkml

On Fri, Aug 30, 2024 at 03:23:32PM -0700, Nathan Chancellor wrote:
On Fri, Aug 30, 2024 at 08:57:47PM +0100, Mark Brown wrote:
quoted
I'm a bit concerned that this isn't picked up by an allmodconfig with
the -Werror...  I'm currently using GCC 12 for that.
It shows up with -Wmaybe-uninitialized for GCC but that's disabled for
the normal kernel build with commit 78a5255ffb6a ("Stop the ad-hoc games
with -Wno-maybe-initialized"). With GCC 12:
...
Perhaps a KCFLAGS=-Wmaybe-uninitialized in your make command or adding

  subdir-ccflags-$(CONFIG_CC_IS_GCC) := -Wmaybe-uninitialized

to the makefiles of the drivers that you maintain might not be a bad
idea.
If it's causing so many false positives that it's been disabled then
that'll just cause trouble, it's always miserable whenever a subsystem
decides to go with custom warning options.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help