Thread (5 messages) 5 messages, 3 authors, 2024-09-02

Re: [PATCH] gpio: rockchip: fix OF node leak in probe()

From: Bartosz Golaszewski <hidden>
Date: 2024-09-02 10:23:45
Also in: linux-gpio, linux-rockchip, lkml

On Mon, Aug 26, 2024 at 5:08 PM Krzysztof Kozlowski
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
Driver code is leaking OF node reference from of_get_parent() in
probe().

Fixes: 936ee2675eee ("gpio/rockchip: add driver for rockchip gpio")
Signed-off-by: Krzysztof Kozlowski <redacted>
---
 drivers/gpio/gpio-rockchip.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c
index 0bd339813110..365ab947983c 100644
--- a/drivers/gpio/gpio-rockchip.c
+++ b/drivers/gpio/gpio-rockchip.c
@@ -713,6 +713,7 @@ static int rockchip_gpio_probe(struct platform_device *pdev)
                return -ENODEV;

        pctldev = of_pinctrl_get(pctlnp);
+       of_node_put(pctlnp);
        if (!pctldev)
                return -EPROBE_DEFER;

--
2.43.0
How about using __free(device_node)?

Bart
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help