On Fri, Aug 30, 2024 at 01:28:36PM +0100, Marc Zyngier wrote:

On Tue, 27 Aug 2024 09:45:45 +0100,
Sebastian Ene [off-list ref] wrote:

quoted

Reuse the descriptor parsing functionality to keep the same output format
as the original ptdump code.

Hello Mark,

This sentence seems either out of place or missing something, because
this change it not reusing anything...

quoted

In order for this to happen, move the state
tracking objects into a common header.

... but instead doing this ^^^.

I propose to rewrite the commit message as:

"Adding a new page-table dumper for stage-2 requires parsing the page
tables, and reusing the descriptor parsing functionality would help
keeping the same output format as the original ptdump code.

In order for this to happen, move the state tracking object
definitions into a common header."

Thanks for the feedback, I think the re-wording works much better and
I'll make use of it.

Shout if you object to it!

Thanks,

	M.

Seb

-- 
Without deviation from the norm, progress is not possible.