Re: [PATCH net-next v3 05/13] net: phy: Fix missing of_node_put() for leds
From: Andrew Lunn <andrew@lunn.ch>
Date: 2024-08-29 12:54:44
Also in:
linux-sunxi, netdev
From: Andrew Lunn <andrew@lunn.ch>
Date: 2024-08-29 12:54:44
Also in:
linux-sunxi, netdev
On Thu, Aug 29, 2024 at 02:31:10PM +0800, Jinjie Ruan wrote:
The call of of_get_child_by_name() will cause refcount incremented
for leds, if it succeeds, it should call of_node_put() to decrease
it, fix it.
Fixes: 01e5b728e9e4 ("net: phy: Add a binding for PHY LEDs")
Signed-off-by: Jinjie Ruan <redacted>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>This is a fix. You were asked to break it out of the series, and post it to net, not net-next. Jonathan, please could you step in and do some mentoring. Huawei is big enough it should not need Maintainers to teach its developers the basics. Andrew