Thread (5 messages) 5 messages, 3 authors, 2024-09-02

Re: [PATCH -next 2/2] clocksource/drivers/cadence-ttc: Add missing clk_disable_unprepare in ttc_setup_clockevent

From: Michal Simek <michal.simek@amd.com>
Date: 2024-08-05 10:17:34


On 8/3/24 08:42, Gaosheng Cui wrote:
quoted hunk ↗ jump to hunk
Add the missing clk_disable_unprepare() before return in
ttc_setup_clockevent().

Signed-off-by: Gaosheng Cui <redacted>
---
  drivers/clocksource/timer-cadence-ttc.c | 6 ++++--
  1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/clocksource/timer-cadence-ttc.c b/drivers/clocksource/timer-cadence-ttc.c
index ca7a06489c40..b8a1cf59b9d6 100644
--- a/drivers/clocksource/timer-cadence-ttc.c
+++ b/drivers/clocksource/timer-cadence-ttc.c
@@ -435,7 +435,7 @@ static int __init ttc_setup_clockevent(struct clk *clk,
  				    &ttcce->ttc.clk_rate_change_nb);
  	if (err) {
  		pr_warn("Unable to register clock notifier.\n");
-		goto out_kfree;
+		goto out_clk_unprepare;
  	}
  
  	ttcce->ttc.freq = clk_get_rate(ttcce->ttc.clk);
@@ -465,13 +465,15 @@ static int __init ttc_setup_clockevent(struct clk *clk,
  	err = request_irq(irq, ttc_clock_event_interrupt,
  			  IRQF_TIMER, ttcce->ce.name, ttcce);
  	if (err)
-		goto out_kfree;
+		goto out_clk_unprepare;
  
  	clockevents_config_and_register(&ttcce->ce,
  			ttcce->ttc.freq / PRESCALE, 1, 0xfffe);
  
  	return 0;
  
+out_clk_unprepare:
+	clk_disable_unprepare(ttcce->ttc.clk);
  out_kfree:
  	kfree(ttcce);
  	return err;
Reviewed-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help