Re: [PATCH 1/5] dt-bindings: phy: imx8mq-usb: add compatible "fsl,imx95-usb-phy"
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2024-08-04 14:16:43
Also in:
imx, linux-devicetree, linux-phy, linux-usb
On 02/08/2024 11:16, Xu Yang wrote:
quoted hunk ↗ jump to hunk
The usb phy in i.MX95 is compatible with i.MX8MP's, this will add a compatible "fsl,imx95-usb-phy" for i.MX95. Also change reg maxItems to 2 since i.MX95 needs another regmap to control Type-C Assist (TCA) block. Since i.MX95 usb phy is able to switch SS lanes, this will also add orientation-switch and port property to the file. Signed-off-by: Xu Yang <xu.yang_2@nxp.com> --- .../bindings/phy/fsl,imx8mq-usb-phy.yaml | 40 +++++++++++++++++-- 1 file changed, 36 insertions(+), 4 deletions(-)diff --git a/Documentation/devicetree/bindings/phy/fsl,imx8mq-usb-phy.yaml b/Documentation/devicetree/bindings/phy/fsl,imx8mq-usb-phy.yaml index dc3a3f709fea..b0a614a9556d 100644 --- a/Documentation/devicetree/bindings/phy/fsl,imx8mq-usb-phy.yaml +++ b/Documentation/devicetree/bindings/phy/fsl,imx8mq-usb-phy.yaml@@ -11,12 +11,17 @@ maintainers: properties: compatible: - enum: - - fsl,imx8mq-usb-phy - - fsl,imx8mp-usb-phy + oneOf: + - enum: + - fsl,imx8mq-usb-phy + - fsl,imx8mp-usb-phy + - items: + - const: fsl,imx95-usb-phy + - const: fsl,imx8mp-usb-phy reg: - maxItems: 1 + minItems: 1 + maxItems: 2 "#phy-cells": const: 0@@ -28,6 +33,17 @@ properties: items: - const: phy + orientation-switch: + description: + Flag the PHY as possible handler of USB Type-C orientation switching
No need to duplicate definitions of properties.
+ type: boolean + + port: + $ref: /schemas/graph.yaml#/properties/port + description: + A port node to link the PHY to a TypeC controller for the purpose of + handling orientation switching.
Same here. You probably miss reference to usb-switch.
quoted hunk ↗ jump to hunk
+ power-domains: maxItems: 1@@ -89,6 +105,22 @@ required: - clocks - clock-names +allOf: + - if: + properties: + compatible: + contains: + enum: + - fsl,imx95-usb-phy + then: + properties: + reg: + minItems: 2
list and describe the items here, instead. Krzysztof