Thread (10 messages) 10 messages, 3 authors, 2024-08-31
STALE697d
Revisions (2)
  1. v2 current
  2. v3 [diff vs current]

[PATCH v2 2/4] irqchip/apple-aic: Skip unnecessary setting of use_fast_ipi

From: Nick Chan <hidden>
Date: 2024-08-31 05:57:15
Also in: asahi, linux-devicetree, lkml
Subsystem: arm/apple machine support, irqchip drivers, the rest · Maintainers: Sven Peter, Janne Grunau, Thomas Gleixner, Linus Torvalds

use_fast_ipi is true by default and there is no need to "enable" it.

Signed-off-by: Nick Chan <redacted>
---
 drivers/irqchip/irq-apple-aic.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c
index 5c534d9fd2b0..8d81d5fb3c50 100644
--- a/drivers/irqchip/irq-apple-aic.c
+++ b/drivers/irqchip/irq-apple-aic.c
@@ -987,9 +987,7 @@ static int __init aic_of_ic_init(struct device_node *node, struct device_node *p
 	off += sizeof(u32) * (irqc->max_irq >> 5); /* MASK_CLR */
 	off += sizeof(u32) * (irqc->max_irq >> 5); /* HW_STATE */
 
-	if (irqc->info.fast_ipi)
-		static_branch_enable(&use_fast_ipi);
-	else
+	if (!irqc->info.fast_ipi)
 		static_branch_disable(&use_fast_ipi);
 
 	irqc->info.die_stride = off - start_off;
-- 
2.46.0

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help