Re: [RESEND PATCH v2 2/2] arm64: dts: mediatek: mt8183-pumpkin: add HDMI support
From: Nícolas F. R. A. Prado <hidden>
Date: 2024-08-30 21:34:15
Also in:
linux-devicetree, linux-mediatek, lkml
On Mon, Aug 19, 2024 at 08:05:56PM +0800, Pin-yen Lin wrote:
From: Fabien Parent <redacted> The MT8183 Pumpkin board has a micro-HDMI connector. HDMI support is provided by an IT66121 DPI <-> HDMI bridge. This commit enables DPI and add the node for the IT66121 bridge.
Make it imperative [1]: Enable the DPI and add the node for the IT66121 bridge. [1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes
Signed-off-by: Fabien Parent <redacted>
You should also add a Co-developed-by tag for yourself since you made (or will make) changes to this commit.
quoted hunk ↗ jump to hunk
Signed-off-by: Pin-yen Lin <redacted> --- (no changes since v1) .../boot/dts/mediatek/mt8183-pumpkin.dts | 121 ++++++++++++++++++ 1 file changed, 121 insertions(+)diff --git a/arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts b/arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts index 1aa668c3ccf9..ecc237355b56 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts
[..]
quoted hunk ↗ jump to hunk
@@ -120,6 +132,41 @@ &i2c6 { pinctrl-0 = <&i2c6_pins>; status = "okay"; clock-frequency = <100000>; + #address-cells = <1>; + #size-cells = <0>; + + it66121hdmitx: hdmitx@4c { + compatible = "ite,it66121"; + pinctrl-names = "default"; + pinctrl-0 = <&ite_pins>; + vcn33-supply = <&mt6358_vcn33_wifi_reg>;
As pointed out by lkp this label doesn't exist: https://lore.kernel.org/all/202408200703.MYO1s3Ne-lkp@intel.com/ (local) See 9a8014b1d4d2 ("arm64: dts: mediatek: mt6358: Merge ldo_vcn33_* regulators").
+ vcn18-supply = <&mt6358_vcn18_reg>; + vrf12-supply = <&mt6358_vrf12_reg>; + reset-gpios = <&pio 160 GPIO_ACTIVE_LOW>; + interrupt-parent = <&pio>; + interrupts = <4 IRQ_TYPE_LEVEL_LOW>; + reg = <0x4c>;
Please take a look at https://docs.kernel.org/devicetree/bindings/dts-coding-style.html for among other things, suggested ordering of properties in nodes. reg is commonly the second property.
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;Add a blank line here.
+ it66121_in: endpoint {
+ bus-width = <12>;
+ remote-endpoint = <&dpi_out>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;Ditto. Reviewed-by: Nícolas F. R. A. Prado <redacted> Thanks, Nícolas