Re: [PATCH v3 4/5] media: platform: mtk-mdp3: Use cmdq_pkt_create() and cmdq_pkt_destroy()
From: Nícolas F. R. A. Prado <hidden>
Date: 2024-08-30 20:28:17
Also in:
dri-devel, linux-media, linux-mediatek, lkml
On Sat, Aug 10, 2024 at 09:09:17AM +0000, Chun-Kuang Hu wrote:
quoted hunk ↗ jump to hunk
Use cmdq_pkt_create() and cmdq_pkt_destroy() common function instead of implementing mdp3 version. Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org> --- .../platform/mediatek/mdp3/mtk-mdp3-cmdq.c | 45 ++----------------- 1 file changed, 4 insertions(+), 41 deletions(-)diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c index 0cddafedbecc..48432d60b49a 100644 --- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c +++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c
[..]
quoted hunk ↗ jump to hunk
@@ -538,7 +501,7 @@ static void mdp_auto_release_work(struct work_struct *work) wake_up(&mdp->callback_wq); } - mdp_cmdq_pkt_destroy(&cmd->pkt); + cmdq_pkt_destroy(mdp->cmdq_clt, &cmd->pkt);
Hi,
this doesn't build:
drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c: In function ‘mdp_auto_release_work’:
drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c:504:29: error: passing argument 1 of ‘cmdq_pkt_destroy’ from incompatible pointer type [-Werror=incompatible-pointer-types]
504 | cmdq_pkt_destroy(mdp->cmdq_clt, &cmd->pkt);
| ~~~^~~~~~~~~~
| |
| struct cmdq_client **
In file included from drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.h:12,
from drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c:10:
./include/linux/soc/mediatek/mtk-cmdq.h:111:43: note: expected ‘struct cmdq_client *’ but argument is of type ‘struct cmdq_client **’
111 | void cmdq_pkt_destroy(struct cmdq_client *client, struct cmdq_pkt *pkt);
| ~~~~~~~~~~~~~~~~~~~~^~~~~~
Same in other instances in this patch and in other patches in the series.
Thanks,
Nícolas