Thread (6 messages) 6 messages, 4 authors, 2024-09-02

Re: [PATCH 2/2] bus: integrator-lm: fix OF node leak in probe()

From: Liviu Dudau <liviu.dudau@arm.com>
Date: 2024-08-29 12:34:39
Also in: lkml, stable

On Mon, Aug 26, 2024 at 07:49:34AM +0200, Krzysztof Kozlowski wrote:
Driver code is leaking OF node reference from of_find_matching_node() in
probe().

Fixes: ccea5e8a5918 ("bus: Add driver for Integrator/AP logic modules")
Cc: <redacted>
Signed-off-by: Krzysztof Kozlowski <redacted>
Acked-by: Liviu Dudau <liviu.dudau@arm.com>

Best regards,
Liviu
quoted hunk ↗ jump to hunk
---
 drivers/bus/arm-integrator-lm.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/bus/arm-integrator-lm.c b/drivers/bus/arm-integrator-lm.c
index b715c8ab36e8..a65c79b08804 100644
--- a/drivers/bus/arm-integrator-lm.c
+++ b/drivers/bus/arm-integrator-lm.c
@@ -85,6 +85,7 @@ static int integrator_ap_lm_probe(struct platform_device *pdev)
 		return -ENODEV;
 	}
 	map = syscon_node_to_regmap(syscon);
+	of_node_put(syscon);
 	if (IS_ERR(map)) {
 		dev_err(dev,
 			"could not find Integrator/AP system controller\n");
-- 
2.43.0
-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help