Re: [PATCH v12 2/2] arm64: dts: apple: add "brcm,bcm4329-fmac" fallback compatible
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2024-08-28 05:57:04
Also in:
asahi, linux-devicetree, linux-rockchip, lkml
On 28/08/2024 05:39, Jacobe Zang wrote:
Broadcom driver need to check "brcm,bcm4329-fmac" compatible. Before
What for?
quoted hunk ↗ jump to hunk
PCIe devices used PCI ID as base compabile so add it as fallback compatible to pass the check. Signed-off-by: Jacobe Zang <redacted> --- arch/arm64/boot/dts/apple/t8103-jxxx.dtsi | 2 +- arch/arm64/boot/dts/apple/t8112-j413.dts | 2 +- arch/arm64/boot/dts/apple/t8112-j493.dts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)diff --git a/arch/arm64/boot/dts/apple/t8103-jxxx.dtsi b/arch/arm64/boot/dts/apple/t8103-jxxx.dtsi index 5988a4eb6efaa..4b021626d4692 100644 --- a/arch/arm64/boot/dts/apple/t8103-jxxx.dtsi +++ b/arch/arm64/boot/dts/apple/t8103-jxxx.dtsi@@ -72,7 +72,7 @@ hpm1: usb-pd@3f { &port00 { bus-range = <1 1>; wifi0: network@0,0 { - compatible = "pci14e4,4425"; + compatible = "pci14e4,4425", "brcm,bcm4329-fmac";
So devices are not compatible, but your argument is that driver needs to do something here? That's not enough. Best regards, Krzysztof