Re: [PATCH v2 11/12] arm64: dts: rockchip: Add rk3576 SoC base DT

On Mon Aug 26, 2024 at 8:28 PM CEST, Detlev Casanova wrote:

On Sunday, 25 August 2024 10:08:24 EDT Chukun Pan wrote:

quoted

quoted

--- /dev/null
+++ b/arch/arm64/boot/dts/rockchip/rk3576.dtsi

...
+		opp-1416000000 {
+			opp-hz = /bits/ 64 <1416000000>;
+			opp-microvolt = <725000 725000 950000>;
+			opp-microvolt-L1 = <712500 712500 950000>;
+			opp-microvolt-L2 = <700000 700000 950000>;
+			opp-microvolt-L3 = <700000 700000 950000>;
+			opp-microvolt-L4 = <700000 700000 950000>;
+			opp-microvolt-L5 = <700000 700000 950000>;
+			clock-latency-ns = <40000>;
+		};
...

I'm curious if these frequencies work properly. On the bsp kernel,
'opp-microvolt-L<name>' is used by the PVTM driver, I don't know
if it works on the upstream kernel.

Which seems to correspond to the set opp-hz value. As mentionned by Alexey, 
the opp-microvolt-L.* values are not used by the driver.

I also have not tested any cpufreq settings/driver on this board yet. I can 
remove the opp-microvolt-L.* for now.

If you run this command on the upstream kernel:
``grep -r "opp-microvolt" arch/arm64/boot/dts/rockchip/``

you'll see it doesn't use the opp-microvolt-LN variants anywhere,
so this is indeed a downstream/BSP only thing.