Re: [PATCH 2/3] drivers: gpio: siul2-s32g2: add NXP S32G2/S32G3 SoCs support
From: Andrei Stefanescu <hidden>
Date: 2024-08-26 14:03:35
Also in:
linux-devicetree, linux-gpio, lkml
From: Andrei Stefanescu <hidden>
Date: 2024-08-26 14:03:35
Also in:
linux-devicetree, linux-gpio, lkml
Hi Linus, On 26/08/2024 12:42, Linus Walleij wrote:
Hi Andrei, thanks for your patch! On Mon, Aug 26, 2024 at 10:43 AM Andrei Stefanescu [off-list ref] wrote:
Thank you for the quick review!
As Krzysztof points out: the driver is based on something really old and needs an overhaul. Luckily GPIO drivers are not that big so it should be pretty straight-forward.
Are there other changes, apart from the ones in this email and those already suggested by Krzysztof, that I should consider for v2? I will fix the other comments in v2. Best regards, Andrei