Re: [PATCH v3 1/2] iio: adc: xilinx-ams: use device_* to iterate over device child nodes

Hi Jonathan,

On 8/26/24 12:52, Jonathan Cameron wrote:

On Tue, 20 Aug 2024 21:02:26 +0200
Javier Carrasco [off-list ref] wrote:

quoted

Use `device_for_each_child_node_scoped()` in `ams_parse_firmware()`
to explicitly state device child node access, and simplify the child
node handling as it is not required outside the loop.

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>

Applied, but I would ideally still like one of the xilinx folk
others familiar with this driver to take a look.  It'll be a
few days before this ends up in next anyway as I need to rebase
after Greg (hopefully) takes the pull request from last week.

I just get back from vacation.

It would be lovely to get rid of the direct fwnode usage
in here but I'm not 100% sure if there is a path that will land
on a disabled fwnode.

Conall: Please take a look at this and test it.

Thanks,
Michal